Difference between revisions of "Template talk:Favor"

Latest revision as of 02:56, 18 March 2017

Link to Favor page

I don't like this latest change. Now many NPC pages have dozens of links to the same page (/Favor). Most people reading will already be familiar with the basic concepts of the game (there's a link to Favor in the Basics section on the main page), i don't think there needs to be a link directing them every time they see a favor requirement. I suggest this be reverted. Alleryn (talk) 04:04, 17 March 2017 (CDT)

If you don't like it, feel free to revert it. The change does nothing except make the link available. It causes no change to the appearance of the Favor display, yet adds the convenience of an easily usable link any time favor is shown. When I was learning this game, I found myself frequently wondering what the favor levels are between where I am at and where I need to be, and also how many favor points are required to get there. I didn't even know the Favor page existed, and just muddled through until I stumbled upon it one day. But even since, each time I've had a question, I've had to search for it. I felt the link to be a convenience to players who have not memorized favor levels (and points between them) yet. I am not sure what the objection is, other than knowing that many links could exist on the page? Is this a performance concern? Arindor (talk) 08:31, 17 March 2017 (CDT)

I can't speak to performance concerns. I expect that transclusion always creates a hit; I don't think making a link would be expensive. But that's only my intuition. I just find it clutters the page and looks bad with that many links to one spot. For me, it's a style concern. I'll leave it as is if no one else finds it off-putting. Alleryn (talk) 14:16, 17 March 2017 (CDT)

On my browser, I'm seeing the exact same behaviour before and after the change to add the links - they're "hidden" unless you mouseover the item, and only then the underline shows. Maybe you're seeing a different behaviour? Perhaps I could make the links completely hidden, such that the underline never shows, but they are still "clickable". Do you think that would help? Arindor (talk) 17:03, 17 March 2017 (CDT)

I do see the underline all the time, but that doesn't really bother me. I guess it's not a big deal; it just feels weird to me to have one page linked so many times. If it doesn't bother anyone else, i'd say just leave it. Alleryn (talk) 17:16, 17 March 2017 (CDT)

How does this look on your browser?

[Favor Level]

That is the only way I could find to remove the underscore and preserve the link (on hover on my side) - wiki really wants links underlined! If it works for you, we can use that as a fallback technique, if desired. Arindor (talk) 22:04, 17 March 2017 (CDT)

There's no underline. Let's go with that. Alleryn (talk) 01:33, 18 March 2017 (CDT)

Implemented. Let me know if any issues! Arindor (talk) 02:56, 18 March 2017 (CDT)